feat(gallery): HLS -> HLS.Light #1510
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 6f35815 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Bundle size report
|
|
Собрана новая демка. |
|
Собрана новая демка. |
denisx
commented
Dec 21, 2024
| hls.on(Hls.Events.ERROR, (_, data) => { | ||
| async function initHls() { | ||
| const { default: Hls } = await import( | ||
| /* webpackChunkName: "hls-js-video" */ 'hls.js/dist/hls.light.mjs' |
There was a problem hiding this comment.
300 Kb в отдельный чанк
|
Собрана новая демка. |
denisx
requested review from
reme3d2y,
fulcanellee,
SiebenSieben and
hextion
as code owners
fulcanellee
approved these changes
Dec 23, 2024
SiebenSieben
approved these changes
Dec 25, 2024
Co-authored-by: Evgeny Sergeev <[email protected]>
|
Собрана новая демка. |
|
Собрана новая демка. |
hextion
requested changes
Dec 26, 2024
There was a problem hiding this comment.
перенести в hls.d.ts как в module.d.ts
| if (playerRef.current) { | ||
| hls.attachMedia(playerRef.current); | ||
| } | ||
| } | ||
|
|
||
| initHls().catch(); |
There was a problem hiding this comment.
может добавим количество попыток загрузки?
hextion
requested changes
Dec 26, 2024
|
|
||
| hls = new Hls(); | ||
|
|
||
| if (!Hls.isSupported()) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Опишите проблему
Ожидаемое поведение
Без изменений
Дополнительная информация
Это официально сокращенная сборка, вот её ограничения:
Если по тестам нам хватает функционала, то зачем грузить больше
P.S. На сайте видео-баннер работает работает в такой light-версии, полёт нормальный
Профитность 110 Kb
Вопросы: надо ли добавлять проверку на тип видео, чтобы использовать нативные способы, когда возможно (и не грузить плеер когда и так сработает). Это можно сделать в след.пр.
(
пример логики с сайта:
https://git.moscow.alfaintra.net/projects/ ALFASITE/repos/akit/browse/packages/common/video-background/src/widgets/video-background/utils/attach-media-to-element.ts
)